leekelleher / umbraco-contentment

Contentment for Umbraco - a state of happiness and satisfaction
https://marketplace.umbraco.com/package/umbraco.community.contentment
Mozilla Public License 2.0
157 stars 72 forks source link

Issue when saving data list with Umbraco Content by XPath #139

Closed wilbert-seansly closed 3 years ago

wilbert-seansly commented 3 years ago

Which Contentment version are you using?

latest 2.1.0

Which Umbraco version are you using? For example: 8.14.1 - don't just write v8

8.14.2

Bug summary

I added a contentment data list to a doctype with a data source of Umbraco Content by XPath. It pulls in the correct items, it lets me save and publish and it even saves the values correctly. However it flashes a message to the user saying their is a problem.

Message is: Cannot access a disposed object. Object name: 'Snapshot'

Capture

Steps to reproduce

Expected result / actual result

I would expect there to not be an error message flash

Do you have Umbraco ModelsBuilder enabled?

What browsers are you seeing the problem on?

Firefox

leekelleher commented 3 years ago

@wilbert-seansly Thanks for raising this.

I haven't seen this error message whilst I've been testing/debugging myself, (I've just tried it out again now, as I'm current working on a website that uses the Content by XPath data-source). So I'm not sure what the underlying issue is - I mean the error message doesn't mention it coming from Contentment code. 🤔 (Strange thing is, accordingly to my telemetry, others are using the Content by XPath, and this is the first bug raised about it).

Do you know if the error happens if the Data List property is removed? (Just trying to rule out Data List.)

Unless if there is some config/setting with ModelsBuilder that I'm not testing for, are you able to provide any more info?

leekelleher commented 3 years ago

@wilbert-seansly I'll close off this ticket. If the issue persists, please feel free to reopen it.