Closed enkelmedia closed 2 years ago
@enkelmedia Thanks for raising this. I was reusing Umbraco's <umb-checkmark>
directive, which only had the icon-check
icon displayed (no toggle). I agree with your suggestion and have amended the markup accordingly. Fixed in commit 5cc1c50f32de6e7dc30cb22bb2fd5874d742a36e. I'll schedule a patch release soon.
@leekelleher I see! Thanks for looking into this so fast =D No need to stress with the patch-release I just wanted to raise the issue so that there could be a small improvement for the editors =D
Cheers!
Which Contentment version are you using?
4.1.5
Which Umbraco version are you using? For example: 8.14.1 - don't just write v8
10.1.0
Bug summary
We're using a Data List configured with a Item Picker that allows for multiple items to be selected.
This used to look something like this: Here the gray color indicates clearly that an item is not selected but due to Umbraco style-updates it looks like this out of the box now:
It looks kind like everything i selected, how ever when an item is actually selected it becomes more clear that the others where not:
I'm proposing that the icon should be removed when an item is not selected making it look like this:
If this is a good idea I'm happy to help out.
Steps to reproduce
Setup a Data List of type "Item Picker" and allow for multiple items to be selected. Click the "Add"-button to see this in the editor sliding in from the right.
Expected result / actual result
It should be very clear that none of the items in the list is selected.
Do you have Umbraco ModelsBuilder enabled?
What browsers are you seeing the problem on?
Chrome