Closed busrasengul closed 1 year ago
Thank you @busrasengul. I'm on holiday at the moment, but will check this PR once I'm back. 👍
I've merged your changes on to my PR @leekelleher Thank you. Looks all great for me :)
Hey @leekelleher,
Just wondering if you had any plans to release v4.5.0 anytime soon? Would be awesome to have this fix into our project!
If there's bigger plans at play here (I can see some incomplete features on the milestone) then no worries / pressure!
Cheers, Callum
@callumbwhyte No bigger plans, just dropped off my radar - I haven't even opened Visual Studio in the past couple of weeks. 😆 I'll get a v4.4.3 patch release out soon (now that you've mentioned this). v4.5.0 (with Data Picker editor) isn't ready yet, (again fell completely off my radar). 😆
@callumbwhyte @busrasengul Contentment v4.4.3 has been released.
Replace $parent with actual parent id.
Description
This PR is now changing the XPath $parent query to actual parent id. And modified where it was used.
We weren't sure where to put the class in subject, so we've put it under a new folder called Xml as the Umbraco one was under the Xml folder. We also couldn't be sure if it should be dependency injectable or not. Happy to change/modify anything.
Related Issues?
307
Types of changes
Checklist