leekelleher / umbraco-contentment

Contentment for Umbraco - a state of happiness and satisfaction
https://marketplace.umbraco.com/package/umbraco.community.contentment
Mozilla Public License 2.0
157 stars 72 forks source link

Content Blocks: Validation error doesn't clear when corrected on child item #315

Open CarlSargunar opened 1 year ago

CarlSargunar commented 1 year ago

Which Contentment version are you using?

4.4.2

Which Umbraco version are you using? For example: 8.14.1 - don't just write v8

10.4.2

Bug summary

With nested element types in Data Blocks, validation errors aren't cleared on Publish, but ARE cleared on save.

I've recorded a screencap of me reproducing this error - zipped up as it's too big otherwise

2023-04-12 22-44-24.zip

Steps to reproduce

Set up a data list using contentblocks, with a required field on one of the element types.

Expected result / actual result

No response

Do you have Umbraco ModelsBuilder enabled?

What browsers are you seeing the problem on?

No response

CarlSargunar commented 1 year ago

Happy to help try and fix this - but I'd need some pointers to know where to start looking (angularJS is not my strongest)

leekelleher commented 1 year ago

Thanks for raising this @CarlSargunar.

This could be with the server-side validation for Content Blocks that I'd added in v4.4.2, commit: 7706d882f189e520003db8c80bfceb1191bf91c9 I'd tried to follow the same pattern as Umbraco's BlockList and NestedContent, so I'm unsure why it wouldn't re-validate on Publish, but it does for Save. 🤔 (I'll give it some thought.)

Deba22 commented 7 months ago

Hi @leekelleher @CarlSargunar

I am facing the same issue in contentment v4.4.5. Just checking if this has been resolved?

leekelleher commented 7 months ago

@Deba22 Unfortunately it hasn't been resolved. I was able to reproduce the issue, but unable to figure out how to fix it. It's open for community help if anyone else knows how to fix it.