leekelleher / umbraco-contentment

Contentment for Umbraco - a state of happiness and satisfaction
https://marketplace.umbraco.com/package/umbraco.community.contentment
Mozilla Public License 2.0
154 stars 70 forks source link

Update CopyContentmentPackageAssets target to run BeforeBuild #350

Closed vsilvar closed 11 months ago

vsilvar commented 11 months ago

Description

This ensure package consumers don't need to do a dotnet build before dotnet publish to have the package assets properly copied to the output

This issue was initially present on the Umbraco Package template, but has since been fixed in https://github.com/umbraco/Umbraco-CMS/pull/11992

Workaround

Currently package consumers have to either:

This issue is also is also present in previous versions, so might be worth backporting the fix.

Steps to reproduce

Install the package Make sure the project is in a clean state and the assets aren't present in App_Plugins yet (dotnet clean) Run dotnet publish The output should now be missing the package assets

Types of changes

Checklist