leekelleher / umbraco-contentment

Contentment for Umbraco - a state of happiness and satisfaction
https://marketplace.umbraco.com/package/umbraco.community.contentment
Mozilla Public License 2.0
154 stars 70 forks source link

package.json and related files are showing in solution after install #400

Closed D-Inventor closed 3 months ago

D-Inventor commented 3 months ago

Which Contentment version are you using?

5.0.0

Which Umbraco version are you using? For example: 13.2.1 - don't just write v13

13.3.0

Bug summary

After installing, at least the package.json file and package-lock.json of contentment are referenced inside my project. This is likely because this version of Contentment uses a razor class library: image image

I've had this exact issue myself before and I fixed it in the URL Tracker here: https://github.com/Infocaster/UrlTracker/blob/v13/develop/src/UrlTracker.Backoffice.UI/UrlTracker.Backoffice.UI.csproj#L20

You can see that the files are explicitly excluded between line 19 and 26

Steps to reproduce

  1. Install the package
  2. Notice the additional files as references inside your project

Expected result / actual result

I should not see the package.json file of contentment. It shouldn't be included in the nuget package. I see that it is included.

Do you have Umbraco ModelsBuilder enabled?

What browsers are you seeing the problem on?

No response

D-Inventor commented 3 months ago

Looking into the NuGet package with the package explorer, I can confirm that it is only package.json and package-lock.json: image

leekelleher commented 3 months ago

Doh! 🤦 Thank you for spotting this @D-Inventor and letting me know. 🙏 I'll tidy it up for a patch release.

niekvanderreest commented 3 months ago

Hi @leekelleher,

This issue is also including a reference to node_modules folder, currently it's causing my solution to get stuck building, i've reverted to v4.7 for the moment, just letting you know. contentment remains an awesome extension and i thank you for your work and commitment!

leekelleher commented 3 months ago

I've got around to patching this up in Contentment v5.0.1.