search

leekelleher / umbraco-robotstxt-editor

An Umbraco package to edit your robots.txt file
https://our.umbraco.org/projects/developer-tools/robotstxt-editor/
MIT License
8 stars 5 forks source link

Umb8 - dashboard created for editing robots txt. #5

Closed emmaburstow closed 4 years ago

emmaburstow commented 5 years ago

This work submitted for your perusal contains the following things:

We have built the dashboard for the package, put in a textarea, gotten the contents of the robots.txt coming back into the text area, gotten it to write anything we add in to the robots.txt file, got notifications working to show if it's successful, put in a button that reloads the filecontents into the textarea.

Still to do: We like the idea that the textarea could be one of those ones that have line numbers in.

Enjoy!

leekelleher commented 5 years ago

:tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada::tada:

Feels like Christmas! 🎁

I'll make time this week to review it and feedback. 😄

LottePitcher commented 5 years ago

Thanks @leekelleher (and a merry christmas!!!). Any comments appreciated, be it relating to solution structure, C# or angular!

Perhaps you also have an opinion on whether it really should be a tree node, instead of a new dashboard item. There's a card on Trello discussing that.

There is a new GETTINGSTARTED.md file that explains how you can get the project post build copying to your own website. Although it shouldn't fall over if you don't follow those instructions, it just won't do anything on post build, and you can do your usual own XCOPY malarkey!

leekelleher commented 5 years ago

OK, I've (finally) got around to doing an initial review. I have feedback - all good, don't worry! 😃 How to best feed it back to you all? I could do it as a PR to this PR? (I know, very meta) or go through line-by-line on this PR? But I fear that I may appear slightly obnoxious. 😝

leekelleher commented 5 years ago

re: the XCOPY, turns out that in copying over v8.0.0 DLLs to a v8.0.1 site, well Umbraco doesn't like that at all and it borks the database! 😱 I adjusted the "Copy Local" in VS so that the build doesn't copy all the Umbraco DLLs to the "/bin/Debug" folder. Just one of the joys of package dev! 😆