search

leemunroe / grunt-email-workflow

A Grunt workflow for designing and testing responsive HTML email templates with SCSS.
MIT License
3.05k stars 339 forks source link

#137 update grunt and packages to latest versions #139

Closed kittyfishfrommars closed 9 months ago

kittyfishfrommars commented 9 months ago

Fixes #137: This update has been successfully tested with grunt v1.6.1and grunt-cli v1.4.3 under node v20.10.0and npm 10.2.5. The need for a node version manager (nvm) is effectively eliminated.

While the cdn-tasks in /grunt were left intact, they have been removed from the taskrunner in aliases.yaml and package.json, due to GDPR-considerations and no means of testing. If you rely on these tasks, they will have to be re-introduced.

From CHANGELOG:

leemunroe commented 9 months ago

@kittyfishfrommars amazing, this looks great.

Could you clarify the CDN task and GDPR concerns? Its not clear to me why removing this is necessary. Sidenote: I don't think Rackspace Cloudfiles is still needed/useful anyway, but AWS S3 could be.

Also could you comment on why you moved the SCSS files to a /default subfolder?

kittyfishfrommars commented 9 months ago

@leemunroe: Thank you for your good work.


GDPR - Privacy Concerns on CDN

The General Data Protection Regulation (GDPR) deals with data collection and how data is being used, particularly if this data identifies an individual - which is the case with emails sent.

At the very least, a CDN will gather access data - if only for technical reasons. Subject to GDPR, data controllers must sign a data processing agreement (DPA) and take additional precautions, especially if any servers are located outside of the EU.

Therefore, I opted to remove the CDN packages from packages.json and their tasks from aliases.yaml, but not from the grunt folder. This way one may re-enable their service on purpose, but will not breach privacy laws accidentally by using grunt-email-workflow.


Separate SCSS by templates

SCSS shared by the templates branded, components and transaction has been moved to its own subfolder to differentiate it from SCSS used by a new template.


I hope this helps. Happy New Year!

leemunroe commented 9 months ago

@kittyfishfrommars amazing work, thank you! 🎉

kittyfishfrommars commented 9 months ago

@leemunroe: My pleasure. Thank you for your review and this helpful tool.