Replace premailer with juice css inliner

leemunroe / grunt-email-workflow

A Grunt workflow for designing and testing responsive HTML email templates with SCSS.

MIT License

3.05k stars 339 forks source link

Replace premailer with juice css inliner #47

Closed leemunroe closed 9 years ago

leemunroe commented 9 years ago

Replaces premailer gem, which is ruby, with juice, node.js.

This should also remove dependency for other gems and Xcode command line tools.

leemunroe commented 9 years ago

Todo:

Plain text version
HTML table attributes e.g. cellpadding, cellspacing

leemunroe commented 9 years ago

@jrit Is it possible to set table cellpadding and cellspacing attributes automagically to "0" with Juice?

jrit commented 9 years ago

Juice doesn't process either right now. Those properties don't have a real clean CSS equivalent. Would providing a default CSS with td{ margin: 0; padding: 0; } be enough, or are there clients that will still render padding by default?

leemunroe commented 9 years ago

@jrit Thanks. I think I can get away with manually adding cellpadding and cellspacing for now. Still seems to render ok. Cheers.