leemunroe / grunt-email-workflow

A Grunt workflow for designing and testing responsive HTML email templates with SCSS.
MIT License
3.05k stars 339 forks source link

Handlebars components over helpers + examples #56

Closed taeo closed 8 years ago

taeo commented 9 years ago

Using components (handlebars partials) is easier and more natural for most designers than writing javascript based helper functions.

This PR:

leemunroe commented 9 years ago

@taeo This looks awesome btw! Just need some time this week to review and test.

taeo commented 9 years ago

@leemunroe - Right on! Hit me back with any feedback / questions once you've had time to review.

leemunroe commented 9 years ago

I like this direction. I think you're right about it being more natural.

  1. Looks like there's an issue in the responsive view for components.html. Didn't get a chance to dig deeper. image
  2. Noticing some issues in Outlook 2013 and Outlook.com when previewed in Litmus. Most likely a margin issue. image
  3. Do you want to go ahead and remove src/css/main.css from the repo?
  4. Consider removing /helpers and updating the readme.
taeo commented 9 years ago

@leemunroe - Thanks for feedback / suggestions. The first issue was word-break related with the long path in the code tag.

These latest updates should cover all your points. :beers:

taeo commented 8 years ago

:+1: