search

leemunroe / grunt-email-workflow

A Grunt workflow for designing and testing responsive HTML email templates with SCSS.
MIT License
3.05k stars 339 forks source link

Add chart component 📈 #80

Closed FGRibreau closed 8 years ago

FGRibreau commented 8 years ago

New chart component:

{{> chart width='534' height='200' params='cht=lc&chd=s:cEAELFJHHHKUju9uuXUc&chco=76A4FB&chls=2.0,0.0,0.0&chxt=x,y&chxl=0:|0|1|2|3|4|5|1:|0|50|100&chg=20,50' alt='beautiful chart' }}
FGRibreau commented 8 years ago

Hum, since the chart is a picture, I don't think it will be possible the only way we have is to set width:100% without height, so the picture will resize depending on the container.

Would you like me to change the template so height & width will only be used for image chart size but not in the <img> itself?

leemunroe commented 8 years ago

@FGRibreau I think so. Here are the Litmus tests with height attribute removed https://litmus.com/checklist/emails/public/8592bc5

FGRibreau commented 8 years ago

@leemunroe thanks for your feedback! I updated the PR :)

leemunroe commented 8 years ago

🎉