leenjewel / openssl_for_ios_and_android

OpenSSL Library for iOS and Android
927 stars 318 forks source link

Fix Android build script #3

Closed davidshen84 closed 7 years ago

davidshen84 commented 7 years ago
protoc --version
libprotoc 3.1.0

which protoc
/usr/local/bin/protoc

I install my protoc from brew. I hope this can help you troubleshoot the issue on your side.

leenjewel commented 7 years ago

I think $pwd_path is better than pwd, pwd is work dir may not script file absolute path

These codes return script file absolute path

SOURCE="$0"
while [ -h "$SOURCE" ]; do
    DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
    SOURCE="$(readlink "$SOURCE")"
    [[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE"
done
pwd_path="$( cd -P "$( dirname "$SOURCE" )" && pwd )"

iOS static library build output to tools/../output/ios/xxxxx ,so I hope Android static library build output to tools/../output/android/xxxxx, we could zip output file folder and release it

davidshen84 commented 7 years ago
leenjewel commented 7 years ago
leenjewel commented 7 years ago

Oh by the way

I have released a version yesterday

Now our output file folder like:

iOS

openssl-curl-ios-output

Android

openssl-curl-ios-output
leenjewel commented 7 years ago

Thank you for your job 👍

davidshen84 commented 7 years ago

Are you sure you want path like android/curl-android-x86? I prefer path like android/curl-x86.

You can simply copy everything under the android directory into an Android project, and you don't need an android label inside an Android project to remind you.

leenjewel commented 7 years ago

Your suggestion is better, android/curl-{ABI} is better, I will change iOS output name like ios/curl-{ARCH}