search

leenooks / phpLDAPadmin

phpLDAPadmin - Web based LDAP administration tool
www.phpldapadmin.org
GNU General Public License v2.0
523 stars 166 forks source link

Fix null arguments sent to non null parameters #205

Closed williamdes closed 1 year ago

williamdes commented 1 year ago

Source: https://sources.debian.org/src/phpldapadmin/1.2.6.3-0.3/debian/patches/Fix-htmlspecialchars-null-PHP-8-mass-edit.patch/ Source: https://sources.debian.org/src/phpldapadmin/1.2.6.3-0.3/debian/patches/Fix-preg_match-null-PHP-8-remove-password.patch/

williamdes commented 1 year ago

Hi @leenooks Could you let me know if this PR and the PHP 8 one are okay please ?

leenooks commented 1 year ago

I havent looked at anything related to 1.2 - my focus is on 2.0 (and other person projects) - but its good that the patches are here for others to find and try - thank you.

My quick look at 1.2 and PHP 8.x seemed that many things needed to be fixed - and, IIRC, the patches here didnt address them all. So I'm concentrating my effort on v2 to replace v1.

Thanks for keep 1.2 alive :)

williamdes commented 1 year ago

I havent looked at anything related to 1.2 - my focus is on 2.0 (and other person projects) - but its good that the patches are here for others to find and try - thank you.

My quick look at 1.2 and PHP 8.x seemed that many things needed to be fixed - and, IIRC, the patches here didnt address them all. So I'm concentrating my effort on v2 to replace v1.

Thanks for keep 1.2 alive :)

I tested the interface for php 8.2 on Debian and as today my patches cover all the normal cases and even some edge cases. Could you merge my work so everyone can benefit from it? I can continue to work on fixing more php 8 stuff