search

leenooks / phpLDAPadmin

phpLDAPadmin - Web based LDAP administration tool
www.phpldapadmin.org
GNU General Public License v2.0
520 stars 166 forks source link

Reset PHP Error Reporting Level #235

Closed cheasles closed 8 months ago

cheasles commented 12 months ago

Running PHP8.1, the mhash function is marked as deprecated so when updating an LM password a warning is emitted causing the update operation to fail, regardless of the settings in php.ini around error_reporting. Turns out, the error reporting level is always reset to E_ALL inside common.php instead of the original value. This MR stores the current reporting setting before disabling, then uses the stored value to reset the reporting setting back to the original instead of E_ALL.

leenooks commented 8 months ago

Thanks for this idea, but I wont merge it. The fix should be to rework the mhash function, but since the 1.2 code base is old, it is unlikey to be done. As v2 is being worked on, any fix should be in there.