search

leenooks / phpLDAPadmin

phpLDAPadmin - Web based LDAP administration tool
www.phpldapadmin.org
GNU General Public License v2.0
548 stars 170 forks source link

Fix #238 - Don't htmlescape request DNs #239

Closed lscorcia closed 1 year ago

lscorcia commented 1 year ago

Fixes issue #238 - currently DNs are htmlescaped while read from the request object, this makes searches fail when looking for html-escaped characters (ampersands, apostrophes, quotes, etc.).

williamdes commented 1 year ago

This fix should be for branch 1.2 I am not sure how you managed to fix it on master branch since it's very different :) Does it work?

lscorcia commented 1 year ago

Honestly, now that I look at it again I'm confused too, must have misclicked something in the GitHub UI. However I can confirm that the fix works, we have already patched our installation. I'll try to fix the PR :)