search

leeper / prediction

Tidy, Type-Safe 'prediction()' Methods
https://cran.r-project.org/package=prediction
Other
89 stars 14 forks source link

Make find_data generic and add method for svyglm #2

Closed carlganz closed 7 years ago

carlganz commented 7 years ago

This is a first draft. find_data and prediction should work fine with svyglm. I was planning on adding some tests, but it appears that packages listed as enhances are not available to the package in testing. When I add survey to suggests I can access it in tests, but it gives a warning about not including packages in both suggests, and enhances. Might need to ask R-dev list if it is possible to use packages from enhances in tests.

margins still won't work for svyglm, but I haven't figured out exactly why yet.

codecov-io commented 7 years ago

Current coverage is 17.77% (diff: 60.00%)

Merging #2 into master will increase coverage by 0.26%

@@             master         #2   diff @@
==========================================
  Files             3          3          
  Lines           177        180     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             31         32     +1   
- Misses          146        148     +2   
  Partials          0          0

Powered by Codecov. Last update 0141049...3452498

leeper commented 7 years ago

This looks really good. It is working for me now with margins.

If we want tests for it, we'll need to move survey to Suggests rather than Enhances, which would be fine with me.