leeper / prediction

Tidy, Type-Safe 'prediction()' Methods
https://cran.r-project.org/package=prediction
Other
89 stars 14 forks source link

Add support for ridge::linearRidge predictions #45

Closed dfrankow closed 4 years ago

dfrankow commented 4 years ago

I went through every item in "Please ensure the following before submitting a PR".

dfrankow commented 4 years ago

NOTE: factors working relies on ridge releasing 2.5. See https://github.com/SteffenMoritz/ridge/issues/3.

dfrankow commented 4 years ago

My mistake.

ridge 2.5 (as yet unreleased) is needed for vcov support, not for factor support.

dfrankow commented 4 years ago

Note also that calculate_se is not implemented. But, I am looking into implementing it.

leeper commented 4 years ago

thanks for this!