search

leepeuker / movary

Self hosted web app to track and rate your watched movies
MIT License
391 stars 14 forks source link

Move webhook endpoints to the REST API #510

Closed JVT038 closed 11 months ago

JVT038 commented 11 months ago

This PR moves the webhooks to the API group instead of web.

Should the other webhook-related functions (such as deleting a webhook URL and regenerating an URL) be moved to the API group as well?

JVT038 commented 11 months ago

Should the webhook payload also be added to the openapi specs?

leepeuker commented 11 months ago

Should the webhook payload also be added to the openapi specs?

Hm, good question. I guess we could document what we really use from the payload (instead of everything the webhhook source provides). On the other site, documenting it would make it easier for people to use the webhook endpoints for other stuff and I do not think I would like to support this. The webhooks are depended on what the third party sends to us and not on how we would like it.