search

leepeuker / movary

Self hosted web app to track and rate your watched movies
MIT License
393 stars 14 forks source link

Use the same photo in person list and detail pages after sync #538

Closed sahinakkaya closed 10 months ago

sahinakkaya commented 11 months ago

Description

When I do docker exec movary php bin/console.php tmdb:person:sync, all the person information including the photos are synced as expected. But the photos in the person list page and person detail page are not same. I think this is a bug.

Version

Nightly

Steps to Reproduce

-

Screenshots

image image

Logs

No response

Server OS

No response

Client Platform

None

Client Device

No response

Client OS

No response

Client Browser

No response

Additional Context

No response

leepeuker commented 11 months ago

Hm this should probably be related to the browser cache. Can you force reload both pages and check what happens?

sahinakkaya commented 11 months ago

I am using Firefox 118.0.2, I force reloaded by holding Shift and clicking the reload button. Still same. I also tried a different browser from my phone which I never signed in and it is still showing different photos. So it is probably not about browser cache.

sahinakkaya commented 11 months ago

By the way, this doesn't bother me at all. I like watching movies and this project makes it even more fun. It is a great project! I just wanted to report the issue here so we know about it. This is great job @leepeuker, I really appreciate the efforts :)

sahinakkaya commented 10 months ago

I am not sure but this might be happening because TMDB_ENABLE_IMAGE_CACHING: 1 in docker compose file. I recently set it to 0 and I don't experience this issue now.

leepeuker commented 10 months ago

Okay, so I found what caused this. On the dashboard we are using the cached version of person images, but on the person page we have hardcoded to use the tmdb image directly. I think we simply forgot to update this place when we added the image caching, so I will adjust this and double check that all places in the frontend are using cached images consistently.