search

leepeuker / movary

Self hosted web app to track and rate your watched movies
MIT License
393 stars 14 forks source link

Show movies from watch list in person detail page #545

Closed sahinakkaya closed 10 months ago

sahinakkaya commented 10 months ago

Fixes #543

I mostly copied existing code and adjusted it to show movies from watch list. I tested it for my user and it works for me.

sahinakkaya commented 10 months ago

After seeing this in action, I think it might be a good idea to also show the same information for directors. I can add it too. Let me know what you think.

Edit: Added it :D I think this version is better but I can revert.

sahinakkaya commented 10 months ago

Some screenshots:

resim resim
leepeuker commented 10 months ago

What about showing all movies together (losing the "From your watchlist") and shade the posters of movies not yet watched or something like that? 🤔 If we add e.g. general playlists later we probably want to include movies which are on an users playlist here too.. If we add e.g. general playlists later we probably want to include movies which are on an users playlist here too.

The whole person page is a construction site, so all ideas are welcome

Edit: Oh and thanks for your first pull request! 🎉

leepeuker commented 10 months ago

What about something like this. We could reuse the filter logic from the other sites and edit it so that you can select to e.g. only show watched, on watch list, etc or select how the movies should be ordered

image

sahinakkaya commented 10 months ago

Yeah, these ideas sound good too. The bad news is I don't know if can implement them :D (sure I can but I mean if I can do it in a reasonable amount of time).

Btw, the whole point of opening this pull request for me is to be able to easily see the movies from watch list at first glance. So I am not sure how we can make this possible with filtering. Oh... What about combining both of your ideas? Show a filter box, allow users to filter movies based on them being in watch list, history or other custom lists AND shade the posters of movies not yet watched?

leepeuker commented 10 months ago

Have a look at my comments please. Afterwards I will approve the PR. The layout will probably change again, maybe to something like I suggested here, but who knows when. So in the meantime this is a great solution to already see the watchlist movies :+1:

sahinakkaya commented 10 months ago

OK, done!

sahinakkaya commented 10 months ago

Converted it to draft because of https://github.com/leepeuker/movary/pull/545#discussion_r1390389897

sahinakkaya commented 10 months ago

Uhm... when is this going to be merged? I can't wait to use it in my server :)