leerob / site

My site built with Next.js, Tailwind, and Vercel.
https://leerob.com
7.2k stars 1.39k forks source link

Fix tweet images not appearing #717

Closed ericshively closed 3 months ago

ericshively commented 5 months ago

Currently your website blog in prod. has the embedded tweets missing their images.

Exhibit A: https://leerob.io/blog/using-nextjs

Following the standard react-tweet library documentation: https://react-tweet.vercel.app/next#adding-nextimage

I've added the minimal missing lines to fix this.

Cloned the repo, added this commit, verified my local instance was pulling the images now, albeit with a little awkward shift via \

vercel[bot] commented 5 months ago

@ericshively is attempting to deploy a commit to the leerob-site Team on Vercel.

A member of the Team first needs to authorize it.

leerob commented 5 months ago

CleanShot 2024-05-28 at 20 32 47@2x

This seems to be working for me. Are you seeing something differently?

ericshively commented 5 months ago
Screen Shot 2024-05-28 at 9 14 34 PM

Oh, only checked Firefox. It seems to be working on Chrome and Safari, desktop and mobile, but I turned off my extensions on Firefox and my screenshot seems to reflect Firefox desktop and mobile.