search

leerob / space-invaders

👾Python clone with a modern twist
https://leerob.io/blog/space-invaders-with-python
MIT License
244 stars 223 forks source link

shoot.wav,invaderkilled.wav #29

Open dauuricus opened 4 years ago

dauuricus commented 4 years ago

Thanks, I used your code as a starting point for learning python. I think it has a very beautiful structure.

Are the file names of these two files reversed?

https://youtu.be/_2yUP3WMDRc?t=76

A version in which two file names are swapped https://youtu.be/3bptgz5M-Xk

leerob commented 4 years ago

Hey @dauuricus, I'm glad it was helpful!

Could you try running it locally and seeing if the correct sounds are fired?

dauuricus commented 4 years ago

I think your invadergame program is best for leaning to write a invadergame like program in python. Thank you :)

I think that shoot.wav is "invaderkilled.wav" and invaderkilled sound is player 's laser shoot sound.

This is maybe original invaders2 version.You can hear player's laser shoot sound and invaderkilled sound. https://youtu.be/kR2fjwr-TzA

This is my swapped 2 files version. https://youtu.be/aowPKIgQCXc

This is my dirty soruce code.WIP... https://gist.github.com/dauuricus/56be1d1c26914177e7b213aa5f56d157

I just changed original file name like shoot.wav to invaderkilled.wav, invaderkilled.wav to shoot.wav. https://gist.github.com/dauuricus/56be1d1c26914177e7b213aa5f56d157

leerob commented 4 years ago

The code still appears to be right: https://github.com/leerob/Space_Invaders/blob/ccb37ac159e8528b41b96c4e6f65c30ed9e421fb/spaceinvaders.py#L448

leerob commented 4 years ago

Oh, you're asking about your own branch. I took a look and nothing sticks out to me at first glance.