Closed IT-MikeS closed 6 years ago
I agree with your code change suggestions and I'll reflect those asap. As for the location to downloads, I like the idea that you came up with in having it as a setting that the user can select but will default to the download folder for the appropriate platform the app is being run on.
Awesome, yeah I think that’s a good approach. I’ll be able to test the new functionality tomorrow and let you know how it works.
On Dec 4, 2017, 5:44 PM -0600, Mike S notifications@github.com, wrote:
I agree with your code change suggestions and I'll reflect those asap. As for the location to downloads, I like the idea that you came up with in having it as a setting that the user can select but will default to the download folder for the appropriate platform the app is being run on. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
Awesome, I'll start working on changes and the user settings stuff
Closed will submit new PR with master branch
Sounds good, thanks!
On Dec 4, 2017, 10:15 PM -0600, Mike S notifications@github.com, wrote:
Closed will submit new PR with master branch — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
Some changes, one big one that I think warrants a version bump from 1.x.x to 2.x.x.
I change the application over to using a module that actually downloads and converts on the machine itself instead of relying on the web-service as it could one day no longer exist.
Implemented the dialog from electron to give better save location control to the user on any electron supported platform.
Fixed odd rendering on the percentage on the progress bar where the % symbol would fall outside the bar.
Cleaned up unused code and dependencies after the switch to the module. (no more axios, or need of ipcRenderer)
What still needs to be done:
Comment code better to reflect new changes.
Test on platforms other than Windows
Better error handling and testing the errors that may occur.
Hope this help!