Closed IT-MikeS closed 6 years ago
Added:
The main benefit of using this over yt-mp3 is that we were bound to that service, this limits you in a few significant ways.
As for why we download an mp4 then convert it to mp3: this is more of a limitation workaround, youtube videos provide audio in mp4 format, we could download this and leave it there, and most modern players and software will be able to read it, but we convert to mp3 to ensure the greatest compatibility across players and platforms.
Well, if it’s one line of HTML to get the styling versus a CSS class, then we should just do that. I was just curious.
On Dec 7, 2017, 12:52 PM -0600, Mike S notifications@github.com, wrote:
@IT-MikeS commented on this pull request. In app/containers/app.container.js:
}
}
render() { if (this.state.showProgressBar) {
- return
; - return (
- Change So the answer is now but without it there is no "link" style to the "a" tag so I'll just remove the href and add css styling — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
IT-MikeS commented 6 years agoNo worries, now hearing it, I like your idea for the output folder settings better. As for the conversion successful message your modification makes sense, I'll make both these changes as soon as I can and the sort order changes too
IT-MikeS commented 6 years agoI made all the modifications in your last comment and I think it looks and feels very good, great suggestions!
leerob commented 6 years agoDo you happen to know what bitrate the mp3s get converted to?
Anyways, just tested everything and I totally agree. The menu option is awesome! I tried downloading short, medium, and long length videos. They all worked really well! Super excited that this now support videos that are 1 hour long. Maybe I'll test it with something that's like a day long haha.
Nice work on this! 🎉
leerob commented 6 years agoDid you have any trouble packaging the app? It's saying it can't find the logo file, but it is definitely there.
IT-MikeS commented 6 years agoFor the answer to the bitrate: its a value we can set in the ffmpeg lib, right now its at 160 (cd quality)
As for the packaging issue, its the path to the icon, pushing a update that should resolve this.
IT-MikeS commented 6 years agoThat should resolve the issue you were having
IT-MikeS commented 6 years agoTest building on windows, and tested with 24 hour video all is working well here
leerob commented 6 years agoLooks good to me! This should allow the user to easily change bitrates from a menu option in the future as well, which is nice 🎉
IT-MikeS commented 6 years agoThat's what I thought too, was going to work on download queue and better preferences menu, what do you think?
leerob commented 6 years agoThat could be pretty neat! One thing I had thought about doing was utilizing Electron DL for something similar. Check it out: https://github.com/sindresorhus/electron-dl
On Dec 12, 2017, 11:47 AM -0600, Mike S notifications@github.com, wrote:
That's what I thought too, was going to work on download queue and better preferences menu, what do you think? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.
IT-MikeS commented 6 years agoOkay i'll work on it, as for electron-dl, I like the idea but I think we'll need to modify it a bit to make it work with youtube videos
Putting all changes from v2 branch into new master branch pull request.
Done:
Needs doing:
downloads
folder as default store for converted files.