Version 2, ridding of reliance on web-service

[IT-MikeS]

Putting all changes from v2 branch into new master branch pull request.

Done:

• swap to module to do downloading and conversion on computer instead of using a web-service.

Needs doing:

• Testing on platforms other than windows
• Create user setting type store where a folder can be set as the download destination to improve flow for user.
• Better comment code to reflect changes made to get to 2.x.x
• Set application to use users platform default downloads folder as default store for converted files.

[IT-MikeS]

Update

Added:

• Converted files go automatically to the appropriate platforms downloads folder.
• Added local conversion function that I had forgot before so now files actually get turned into mp3
• Separated the progress for download and conversion, downloading to 100% then converting to 100%

Currently working on:

• Allowing user to set a default folder that will persist through application exit and re-open.
• Creating better error handling and testing possible common errors.
• Progressively commenting and refactoring to clean up names and make everything more understandable

Needs doing that I can not accomplish:

• Testing application on other platforms

[IT-MikeS]

Update

Added:

• Function to allow user to set a default folder that will persist through application exit and re-open.
• Some more comments

[IT-MikeS]

The main benefit of using this over yt-mp3 is that we were bound to that service, this limits you in a few significant ways.

• If they disappear the app breaks
• They have only so many "workers" on their server which can lead to long wait times to download and convert a video
• Progress tracking on the web-service can be spotty
• Any time their API changes the app needs an update

As for why we download an mp4 then convert it to mp3: this is more of a limitation workaround, youtube videos provide audio in mp4 format, we could download this and leave it there, and most modern players and software will be able to read it, but we convert to mp3 to ensure the greatest compatibility across players and platforms.

[leerob]

Well, if it’s one line of HTML to get the styling versus a CSS class, then we should just do that. I was just curious.

On Dec 7, 2017, 12:52 PM -0600, Mike S notifications@github.com, wrote:

@IT-MikeS commented on this pull request. In app/containers/app.container.js:

 }

}

render() { if (this.state.showProgressBar) {

• return ;
• return (
• Change So the answer is now but without it there is no "link" style to the "a" tag so I'll just remove the href and add css styling — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[IT-MikeS]

No worries, now hearing it, I like your idea for the output folder settings better. As for the conversion successful message your modification makes sense, I'll make both these changes as soon as I can and the sort order changes too

[IT-MikeS]

I made all the modifications in your last comment and I think it looks and feels very good, great suggestions!

[leerob]

Do you happen to know what bitrate the mp3s get converted to?

Anyways, just tested everything and I totally agree. The menu option is awesome! I tried downloading short, medium, and long length videos. They all worked really well! Super excited that this now support videos that are 1 hour long. Maybe I'll test it with something that's like a day long haha.

Nice work on this! 🎉

[leerob]

Did you have any trouble packaging the app? It's saying it can't find the logo file, but it is definitely there.

[IT-MikeS]

For the answer to the bitrate: its a value we can set in the ffmpeg lib, right now its at 160 (cd quality)

As for the packaging issue, its the path to the icon, pushing a update that should resolve this.

[IT-MikeS]

That should resolve the issue you were having

[IT-MikeS]

Test building on windows, and tested with 24 hour video all is working well here

[leerob]

Looks good to me! This should allow the user to easily change bitrates from a menu option in the future as well, which is nice 🎉

[IT-MikeS]

That's what I thought too, was going to work on download queue and better preferences menu, what do you think?

[leerob]

That could be pretty neat! One thing I had thought about doing was utilizing Electron DL for something similar. Check it out: https://github.com/sindresorhus/electron-dl

On Dec 12, 2017, 11:47 AM -0600, Mike S notifications@github.com, wrote:

That's what I thought too, was going to work on download queue and better preferences menu, what do you think? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[IT-MikeS]

Okay i'll work on it, as for electron-dl, I like the idea but I think we'll need to modify it a bit to make it work with youtube videos