search

leeroybrun / glacier-vault-remove

Remove all archives stored inside an Amazon Glacier vault, even if you have a huge number of them.
379 stars 50 forks source link

Time on log #6

Closed deadlyhifi closed 8 years ago

deadlyhifi commented 9 years ago

Time of log as this can take quite some time it's nice to know when things happened. Plus a few type changes… and in utf-8

leeroybrun commented 8 years ago

Hello,

Thanks for your submission, and sorry for the delay!

There was a problem with the file encoding that I've fixed. Maybe this fixed the problem with ArchiveID too, let me know.

I've implemented some of your changes in the lasts commits (time in logging and typo fixes), thanks for that.

If the encoding of the ArchiveID is still a problem, do not hesitate to make a new pull request with only this change.

It's good if you create commits for every changes (one commit for time in logging, one for encoding, one for typo fixes, etc), and not only one commit with all changes inside. It's easier to see and validate changes for me then.

Thanks again, and have a great day!

Best regards,

Leeroy

deadlyhifi commented 8 years ago

Thank you. I realise now about splitting commits up. I was fairly new to git back then and I've learnt a lot since.