search

leerssej / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

(Trivial) lots of unnecessary whitespace in output to stdout #204

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. cd /path/to/google-refine
2. ./refine

What is the expected output? What do you see instead?

java.util.Formatter (?) is adding lots of white space between the square 
brackets. I assume this is to make the right-hand log info more readable. See 
log:

13:53:41.823 [            refine_server] Starting Server bound to 
'127.0.0.1:3333' (0ms)
13:53:41.826 [            refine_server] Max memory size: 1024M (3ms)
13:53:41.906 [            refine_server] Initializing context: '/' from 
'/home/tim/Sources/google-refine/main/webapp' (80ms)
13:53:42.970 [            refine_server] Starting autoreloading scanner...  
(1064ms)
13:53:44.316 [                   refine] Starting Google Refine 2.0 [TRUNK]... 
(1346ms)
13:53:44.349 [       FileProjectManager] Using workspace directory: 
/home/tim/.local/share/google/refine (33ms)
13:53:44.351 [       FileProjectManager] Loading workspace: 
/home/tim/.local/share/google/refine/workspace.json (2ms)
13:53:44.497 [                butterfly] Starting butterfly ... (146ms)
13:53:44.497 [                butterfly] Properties loaded from 
/home/tim/Sources/google-refine/main/webapp/WEB-INF/butterfly.properties (0ms)
13:53:44.497 [                butterfly] Autoreloading is enabled (0ms)
13:53:44.563 [                butterfly] > process properties (66ms)
13:53:44.563 [                butterfly]  Butterfly home: 
/home/tim/Sources/google-refine/main/webapp (0ms)
13:53:44.564 [                butterfly] < process properties (1ms)
13:53:44.564 [                butterfly] > load modules (0ms)
13:53:45.212 [                butterfly] < load modules (648ms)
13:53:45.212 [                butterfly] > create modules (0ms)
13:53:47.258 [                butterfly] < create modules (2046ms)
13:53:47.258 [                butterfly] > load module wirings (0ms)
13:53:47.259 [                butterfly]  Loaded module wirings from: 
/home/tim/Sources/google-refine/main/webapp/WEB-INF/modules.properties (1ms)
13:53:47.259 [                butterfly] < load module wirings (0ms)
13:53:47.259 [                butterfly] > wire modules (0ms)
13:53:47.260 [                butterfly]  mounting modules (1ms)
13:53:47.260 [                butterfly]  No mount point defined for module 
'jython', mounting to '/extension/jython' (0ms)
13:53:47.262 [                butterfly]  No mount point defined for module 
'freebase', mounting to '/extension/freebase' (2ms)
13:53:47.262 [                butterfly]  No mount point defined for module 
'gdata', mounting to '/extension/gdata' (0ms)
13:53:47.262 [                butterfly]  No mount point defined for module 
'sample', mounting to '/extension/sample' (0ms)
13:53:47.263 [                butterfly] < wire modules (1ms)
13:53:47.263 [                butterfly] > configure modules (0ms)
13:53:47.886 [                butterfly] < configure modules (623ms)
13:53:47.886 [                butterfly] > initialize modules (0ms)
13:53:49.701 [                butterfly] < initialize modules (1815ms)
13:53:51.152 [                butterfly] GET / [main] (1451ms)
13:53:51.450 [                butterfly] GET /index-bundle.js [main] (298ms)
13:53:51.459 [                butterfly] GET 
/externals/jquery-ui/css/ui-lightness/jquery-ui-1.8.custom.css [main] (9ms)
13:53:51.467 [                butterfly] GET /styles/jquery-ui-overrides.less 
[main] (8ms)
13:53:51.477 [                butterfly] GET /styles/common.less [main] (10ms)
13:53:51.486 [                butterfly] GET /styles/pure.css [main] (9ms)
13:53:51.515 [                butterfly] GET /styles/index.less [main] (29ms)
13:53:51.999 [                   refine] GET 
/command/core/get-all-project-metadata (484ms)
13:53:52.005 [                   refine] GET /command/core/get-version (6ms)
13:53:52.012 [                butterfly] GET /images/logo-googlerefine-40.png 
[main] (7ms)
13:53:52.074 [                butterfly] GET /images/logo-gem-150.png [main] 
(62ms)
13:53:52.076 [                butterfly] GET /images/close.png [main] (2ms)

Original issue reported on code.google.com by mcnamara.tim@gmail.com on 15 Nov 2010 at 12:58

GoogleCodeExporter commented 9 years ago 
What is your proposed format?  Why is it better?

Changing the logging formatter is probably all that's required for this, but 
since it's a style preference you're never going to please everyone.

Original comment by tfmorris on 16 Nov 2010 at 5:46

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 16 Nov 2010 at 6:05

GoogleCodeExporter commented 9 years ago 
The whitespace is necessary to provide enough information to show packages when 
log4j channels are actually java classes (which is most the time). This is 
trivial to change by using a different log formatter in the log4j.properties 
configuration file. The log formatter we're using is able to handle 
sophisticated uses of logs (for example > indents and < outdents at the 
beginning of log strings) but since it's very simple to change to use a more 
standard log4j formatter, I'm closing this one as a won't fix.

Original comment by stefa...@google.com on 24 Dec 2010 at 9:23