[bug] Incorrect information in the README file

leetal / ios-cmake

A CMake toolchain file for iOS/iPadOS, visionOS, macOS, watchOS & tvOS C/C++/Obj-C++ development

BSD 3-Clause "New" or "Revised" License

1.91k stars 450 forks source link

[bug] Incorrect information in the README file #156

Closed arsdever closed 4 months ago

arsdever commented 2 years ago

Describe the bug The README file states the OS64COMBINED flag builds a fat lib including iphoneOS and iphoneOS Simulator, but in the toolchain file the statement is completely different.

To Reproduce

Expected behavior The documentation is correct

Environment

#    OS64COMBINED = Build for arm64 x86_64 iphoneOS. Combined into FAT STATIC lib (supported on 3.14+ of CMakewith "-G Xcode" argument ONLY)

leetal commented 2 years ago

This has now been clarified the the ios.toolchain.cmake file as well as that the cmake --install step is necessary. Please respond is OK, and then I'll close this issue.

arsdever commented 2 years ago

@leetal my main concern is that on the main page, master branch, the information is still incorrect in the README.md. I read there, that the fat lib can be generated via specifying OS64COMBINED, which is not correct.