search

leetal / ios-cmake

A CMake toolchain file for iOS/iPadOS, visionOS, macOS, watchOS & tvOS C/C++/Obj-C++ development
BSD 3-Clause "New" or "Revised" License
1.89k stars 448 forks source link

Remove optimisation causing failures #198

Closed JonasVautherin closed 6 months ago

JonasVautherin commented 9 months ago

Resolves #146.

This seems like an optimisation (it should be fine, though suboptimal, to sometimes run the toolchain twice) that breaks some use-cases (different people complained in #146). I therefore believe that it should be removed (and brought back properly if there is a need at some point).

Also @leetal said:

I cannot remember either why i changed that in the first place... Seems to run equally good using both the "old" solution as with the ENV solution.

Seems like it should be fine to just remove it.

JonasVautherin commented 7 months ago

@leetal kindly pinging here :blush:

JonasVautherin commented 6 months ago

I don't think this will get more attention, so I'm closing this to clean my list of open PRs.

leetal commented 6 months ago

I'm afraid this could break existing uses of the toolchain. I'd love to integrate this fix since it will most definitely fix more than it breaks.. I can probably add some tests that covers Conan or similar use-cases just to be sure but really the only option viable would probably be to introduce a flag to gradually roll this out.