search

leethomason / tinyxml2

TinyXML2 is a simple, small, efficient, C++ XML parser that can be easily integrated into other programs.
zlib License
5.11k stars 1.84k forks source link

fixed `knownConditionTrueFalse` Cppcheck warning #958

Closed firewave closed 12 months ago

firewave commented 1 year ago

*(p+2) is already checked in the preceding if-condition, so it is redundant

leethomason commented 12 months ago

That is correct - but only a computer could figure that out. (There's way too much code between the checks for visual inspection.) Points out some code that really needs to get cleaned up.