leethomason / tinyxml2

TinyXML2 is a simple, small, efficient, C++ XML parser that can be easily integrated into other programs.
zlib License
5.11k stars 1.84k forks source link

Fix compiler error: /tinyxml2.h:2268:18: error: [-Werror=overloaded-virtual=] #985

Open EvEggelen opened 5 months ago

EvEggelen commented 5 months ago

I get an error after updating to the latest ESP idf v5.2.1 ( platformIO Espressif 32 v6.7.0 ) when compiling tinyxml2.

But making explicit what was intended this error is solved. See log below:

Compiling .pio/build/4d_systems_esp32s3_gen4_r8n16/liba1d/tinyxml2/tinyxml2.o In file included from .pio/libdeps/4d_systems_esp32s3_gen4_r8n16/tinyxml2/contrib/html5-printer.cpp:43: .pio/libdeps/4d_systems_esp32s3_gen4_r8n16/tinyxml2/contrib/../tinyxml2.h:2268:18: error: 'virtual void tinyxml2::XMLPrinter::CloseElement(bool)' was hidden [-Werror=overloaded-virtual=] 2268 | virtual void CloseElement( bool compactMode=false ); | ^~~~ .pio/libdeps/4d_systems_esp32s3_gen4_r8n16/tinyxml2/contrib/html5-printer.cpp:66:18: note: by 'virtual void XMLPrinterHTML5::CloseElement()' 66 | virtual void CloseElement () { | ^~~~ cc1plus: some warnings being treated as errors *** [.pio/build/4d_systems_esp32s3_gen4_r8n16/liba1d/tinyxml2/contrib/html5-printer.o] Error 1