search

leetreveil / musicmetadata

Streaming music metadata parser for node and the browser.
561 stars 66 forks source link

Aborts stream file reader once metadata are returned #116

Closed rodu closed 8 years ago

rodu commented 8 years ago

This change relates to issue 115: https://github.com/leetreveil/musicmetadata/issues/115

leetreveil commented 8 years ago

I've fixed the test runner issue. Can you rebase?

rodu commented 8 years ago

Sure, just rebased.

leetreveil commented 8 years ago

I wonder if a better solution would be to add an option to allow musicmetadata to auto close the underlying stream once parsing has finished?

Something like:

var mm = musicmetadata(stream, {autoClose: true})
Skeen commented 8 years ago

This patch seems to have broken my code. My input is a stream, and it does NOT have a '.dest' field.