search

leetreveil / musicmetadata

Streaming music metadata parser for node and the browser.
561 stars 66 forks source link

Rudimentary support for lyrics #118

Closed xhocquet closed 8 years ago

xhocquet commented 8 years ago

I'm not too familiar with how frames and stuff work for music files, but this at least lets me pull out the text which I can modify to my liking afterwards.

Should be a lot easier to flesh out if you've already worked on this stuff!

I'm also developing Node on Windows, so the dist may want to be recompiled on the source machine.

leetreveil commented 8 years ago

Would be great if we could write a test with a SYLT frame.

xhocquet commented 8 years ago

Could you guide me on how to supply that tag specifically for id3v2? I don't see other examples of file-specific tags being added, and removing that line 50 stops parsing lyrics from valid files.

leetreveil commented 8 years ago

Do you have an .mp3 file with a SLYT frame?

xhocquet commented 8 years ago

Yes. With the added line in index.js I'm able to see the lyrics using example.html. however when I remove that line it is no longer added to the results in either index.html or the tests.

xhocquet commented 8 years ago

Updated to what should be working, except lyrics aren't being added once I remove the line from index.js.

leetreveil commented 8 years ago

Added SYLT frame parsing. See https://github.com/leetreveil/musicmetadata/blob/1972aa3ccf0cec29f1f44528700a046fa8fc4c46/test/test-id3v2-lyrics.js for usage