Kanerogers/issue227 - Githubissues

leetvr / hotham

Hotham is a tool for creating incredible standalone VR games.

Apache License 2.0

396 stars 28 forks source link

Kanerogers/issue227 #365

Closed kanerogers closed 2 years ago

kanerogers commented 2 years ago

What is this related to?

Closes #227

What changed?

See #227

What is the overall impact?

Significantly cleaned up public API
Made way for future restructuring

Reviewer notes:

You may see a pattern of x_system and x_ystem_inner. This is specifcally to allow unit tests to not have to spin up the entire engine.
These inner functions should be private, but if some integration test depends on them, they can be changed to pub(crate)
This had the pleasant side effect of revealing that some of Crab Saber's tests unnecessarily depended on the behaviour of unrelated systems

kanerogers commented 2 years ago

Since this one is just refactoring, rather than any significant code change, I'm going to use BDFL powers here and merge this one in!