leewillis77 / wp-github-oembed

WordPress Github "oEmbed" plugin
GNU General Public License v2.0
69 stars 19 forks source link

Plugin doesn't work #23

Closed giacomocerquone closed 6 years ago

giacomocerquone commented 6 years ago

Hi, I downloaded, installed and enabled this plugin on italiancoders but nothing shows-up. What can I check to understand the cause of the problem? Could be the theme that is blocking the plugin?

Wp version: 4.9.1

leewillis77 commented 6 years ago

Can you provide a URL to the page that you're trying to embed something on, and the URL that you're trying to embed.

giacomocerquone commented 6 years ago

Wooa this was quick :smile:

Post link: https://italiancoders.it/routing-delle-applicazioni-angular/ Github repo link: https://github.com/giacomocerquone/angular-routing.git

In the mean time I was looking at your preg_match, I'm about to try to link the issues section in order to see what happens

UPDATE: Issues template is not working too

leewillis77 commented 6 years ago

The GitHub repo link shouldn't have .git on the end, it should just be:

https://github.com/giacomocerquone/angular-routing

That embeds just fine for me, see: https://www.leewillis.co.uk/github-embed/

giacomocerquone commented 6 years ago

Changed, still doesn't work

It works on your website maybe because of the theme as I said (or some other settings)

leewillis77 commented 6 years ago

I can't see the URL anywhere on https://italiancoders.it/routing-delle-applicazioni-angular/ ?

giacomocerquone commented 6 years ago

At "Tutto il codice di questo articolo potete trovarlo sulla relativa repo del mio profilo di github: angular-routing"

leewillis77 commented 6 years ago

That's a link to the repo with specific text - the plugin won't touch that.

What you should have is the URL you want to embed in your content on a line by itself, e.g.

screenshot 2017-12-12 15 44 05

giacomocerquone commented 6 years ago

I tried that too. Anyway we have the website down right now, as soon as it comes back online I'll try this.

Thank you very much for now!

giacomocerquone commented 6 years ago

Spectacular, it works now! Thanks