Questions about "adjust_target_weight"

leeyegy / SimCC

[ECCV'2022 Oral] PyTorch implementation for: SimCC: a Simple Coordinate Classification Perspective for Human Pose Estimation (http://arxiv.org/abs/2107.03332). Old name: SimDR

326 stars 31 forks source link

Questions about "adjust_target_weight" #11

Closed yuzheyyyy closed 2 years ago

yuzheyyyy commented 2 years ago

https://github.com/leeyegy/SimDR/blob/30845b85a139a1ca88ee9f80e9e11b8ae677a7ec/lib/dataset/JointsDataset.py#L384 Should the if condition be "ul[0] >= (self.image_size[0])" rather than "ul[0] >= (self.image_size[0]*self.simdr_split_ratio)"? Since mu_x here is the value that is without multiplying with self.simdr_split_ratio.

leeyegy commented 2 years ago

Yes! Thanks for your pointing out.