search

lefnire / tforce_btc_trader

TensorForce Bitcoin Trading Bot
http://ocdevel.com/podcasts/machine-learning/26
GNU Affero General Public License v3.0
814 stars 234 forks source link

Live-mode NotImplementedError #28

Open alirezaseifi opened 6 years ago

alirezaseifi commented 6 years ago

This is a TODO. so I create it as an issue to fix if I figure it out

File "run.py", line 48, in main env.run_live(agent, test=args.test_live) File "tforce_btc_trader/btc_env.py", 
line 438, in run_live self.run_deterministic(runner, print_results=True) File 
"tforce_btc_trader/btc_env.py", line 389, in run_deterministic next_state, terminal, reward = 
self.execute(runner.agent.act(next_state, deterministic=True, independent=True)) File 
"tforce_btc_trader/btc_env.py", line 343, in execute raise NotImplementedError NotImplementedError

** hint

See https://github.com/lefnire/tforce_btc_trader/commit/6fc4ed20bfa898d2b2787c594ad3f5b8f0b156ce for prior live-mode code which worked. Much has changed since then and it won't work inthat state, so removing and leaving to you to fix (and submit PR please!)

lefnire commented 6 years ago

FWIW I'm not going to fix/implement this until I'm personally confident we've developed an agent which can actually make people money. I don't believe the agent in it's current state is capable, and will need some tweaks to get there - so I think it'd be irresponsible to make it too easy for devs to flip the switch to go live & likely lose money. In the mean time, if they really want to try it they have that hint there they can work from, providing a sort of "you've been warned" barrier-to-entry

alirezaseifi commented 6 years ago

@lefnire Fair argument, but I believe whoever is willing to try this, they'd also be responsible for its end result. if more people try it, you'll get more contribution to the project. everyone should know trading with bot is risky.

And on the other hand, the good thing about this project is the developer needs to run the trainer to get the best result and then try the live trading with the best result ID so the risk is in the developer's hand and I still believe we need to consider this as an open issue to implement the paper version (trading with live asset but not implement the buy and sell )

lefnire commented 6 years ago

That's a good point about needing to train first. Yeah, let's leave this open.