search

lefou / pojosr

A service registry that enables OSGi style service registry programs
5 stars 2 forks source link

support external classpath scanning #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi

i'm start evaluating your project. 

I need to load bundles from external classpath (i.e. URLClassLoader)  and for 
this reason i've attached a new version of ClasspathScanner supporting this 
feature.

I hope you will want to merge it.

Original issue reported on code.google.com by bartolom...@gmail.com on 2 Nov 2012 at 8:42

Attachments:

GoogleCodeExporter commented 9 years ago 
Yeah, that makes sense. I commited something in r67. I did it slightly 
different from your version in that I added a classloader parameter to the 
methods and did not make it so that you can pass it to the constructor. I hope 
that works for you.

Thanks for the idea. Just in time too, I'll make it part of 0.2.0 (which im 
going to release right now).

Original comment by karlpauls on 4 Nov 2012 at 8:07

GoogleCodeExporter commented 9 years ago 
Hi, thx for update 

I think that  there is a lack 

instead of    
=======
158 bundles.add(new BundleDescriptor(getClass().getClassLoader(), 
159                               getParentURL(manifestURL),    
160                             headers));

It would be better
============
bundles.add(new BundleDescriptor( loader, 
                             getParentURL(manifestURL), 
                            headers));

Original comment by bartolom...@gmail.com on 5 Nov 2012 at 10:01

GoogleCodeExporter commented 9 years ago 
rats. yes. I agree. Fixed in r74. 

I deployed a new snapshot so you should be able to test against 0.3.0-SNAPSHOT. 
Can you verify that it is working for you? 

Sorry again.

Original comment by karlpauls on 5 Nov 2012 at 10:12

GoogleCodeExporter commented 9 years ago 
It works!

Your project is really useful!!!

i'm waiting for release

Thanks in advance

Original comment by bartolom...@gmail.com on 5 Nov 2012 at 4:02

GoogleCodeExporter commented 9 years ago 
Thanks. I'll try getting a 0.2.1 out asap.

Original comment by karlpauls on 5 Nov 2012 at 4:07