refs #30 add support for X-Ray and full MethodSettings(incl. Cloudwatch Detailed Monitoring)

leftclickben / serverless-api-stage

AWS API Gateway stage plugin for serverless framework

MIT License

47 stars 16 forks source link

refs #30 add support for X-Ray and full MethodSettings(incl. Cloudwatch Detailed Monitoring) #31

Open mandyjohar23 opened 5 years ago

mandyjohar23 commented 5 years ago

Fixes #30

roni-frantchi commented 4 years ago

Thanks @mandyjohar23 .
Hey @leftclickben can we get this one in? Really need this one.

sambP commented 4 years ago

@mandyjohar23 so currently, it is not possible to use something like this, right?

  stageSettings:
    MethodSettings:
      - ResourcePath: '/~1api~1auth'
        HttpMethod: '*'
        ThrottlingBurstLimit: 1
        ThrottlingRateLimit: 1

sambP commented 4 years ago

I tested my settings above with your pr, but it didn't seem to work.

mandyjohar23 commented 4 years ago

@sambP You can try to do sls package first(with plugin) and see if the local Cloudformation template has all the required properties that you want or not. If the CF template is correct then the deployment shouldn't have any problem.

sambP commented 4 years ago

I searched in the cloudformation-template-create/udpate-stack.json file after a fresh "serverless package" for "thrott", but could not find anything.

My package.json "serverless-api-stage": "leftclickben/serverless-api-stage#31/head",

plugins:
  - serverless-api-stage

This is strange.