search

lefthandedgoat / canopy

f# web automation and testing library, built on top of Selenium (friendly to c# also)
http://lefthandedgoat.github.io/canopy/
MIT License
506 stars 115 forks source link

Typo in docs #472

Closed olivercoad closed 5 years ago

olivercoad commented 5 years ago

In the docs getting started there is a typo in step 4:

canopy.configruation.chromeDir <- AppContext.BaseDirectory

should be 

canopy.configuration.chromeDir <- System.AppContext.BaseDirectory

Would just make a pull request but that line doesn't exist in the index.fsx file 🤨. https://github.com/lefthandedgoat/canopy/blob/e8d81c81dd5d279459d574c5e9e8c41180089c7e/docs/content/index.fsx#L48-L53

lefthandedgoat commented 5 years ago

Thanks. I've fixed this.

It doesnt exists in the fsx file because thats the source that generates the documentation (that lives on gh-pages branch). After updating to .net core the tooling that I used to documents wasnt working, or I was too lazy or something. Thanks again for letting me know!

olivercoad commented 5 years ago

Ok, are you just updating the html files manually in the gh-pages branch at the moment then? Is there anything that can be done to help fix that?

configruation is still spelled wrong, should be configuration.

lefthandedgoat commented 5 years ago

Correct.

In terms of fixing, I probably just need to update everything I used. canopy is like 8 years old and the build scripts are probably 6 and haven't been updated cause they always 'just worked'. Then with .net core I think they stopped but I spent 40 hours on that so fixing documentation scripts wasnt high on the list of things to do =\

olivercoad commented 5 years ago

Thanks. Had no idea canopy was that old. Tried it for the first time last night and it's brilliant!

lefthandedgoat commented 5 years ago

Awesome, please open a ticket if you have any questions and I will be happy to help! Thanks for bringing up these issues!