Closed kaeedo closed 4 years ago
Sorry, for some reason I dont always get notifications on my phone of new issues, so I never saw this.
Honestly I added that so long ago that I can't tell you why it is the way it is. I don't even know if people use it, someone asked for it so I added it.
I probably thought the syntax of runFor [chrome; firefox; ie]
was clean.
Ok. In that case I'd like to make a Pull Request with the changes I proposed. The usage syntax would remain the same, but will become Type Safe
https://github.com/lefthandedgoat/canopy/blob/master/src/canopy/runner.fs#L241
It seems that it would be simpler and more correct to have browsers be of a concrete type that accepts either
BrowserStartModes
orWebDrivers
. This would give compile time safety to what is being passed in.Something like this:
Usage form C# would also remain simple: