Option to select WebDriver port and allow insecure SSL cert

lefthandedgoat / canopy

f# web automation and testing library, built on top of Selenium (friendly to c# also)

http://lefthandedgoat.github.io/canopy/

MIT License

507 stars 115 forks source link

Option to select WebDriver port and allow insecure SSL cert #482

Closed OmanF closed 5 years ago

OmanF commented 5 years ago

Added configuration flag to specifiy port number for the WebDriver instance to listen on (instead of the default randomized one). Currently, Chrome-family ONLY!
Added configuration flag to allow insecure SSL certs to be accepted, as without this, Chrome Headless is all but useless. Currently, Chrome-family ONLY!
Added documentation of above mentioned changes in correct file.
A lot of stylistic cleanup, reformatting and reflowing suggested by Fantomas formatter tool.

lefthandedgoat commented 5 years ago

I appreciate the contribution but they way it was formatted was fine in my book.

Can you re-submit with just the actual functionality?

OmanF commented 5 years ago

I'm not sure if I did it correctly, but I reverted the formatting changes and re-applied the functionality on my fork so, I'm guessing, it also updated the PR? (I'm kinda new to the PR thingie).

lefthandedgoat commented 5 years ago

I will let you know when I get a new build out.

OmanF commented 5 years ago

Appreciate it. Thanks!

lefthandedgoat commented 5 years ago

https://www.nuget.org/packages/canopy/2.1.1

You can download the updates now, thanks again!

OmanF commented 5 years ago

Oh, wow! My first ever PR on a public project merged and live.

Thank you very much!