lefticus / raycasting

Apache License 2.0
15 stars 4 forks source link

Streaming Task List #3

Open lefticus opened 1 year ago

lefticus commented 1 year ago
kolbyb commented 1 year ago

I have a PR to fix the perpendicular intersection bug using a Segment intersection test rather than relying on the Line slope intersection.

See: https://github.com/lefticus/raycasting/pull/6/files

Feel free to use as much or as little on stream as you'd like.

lefticus commented 1 year ago

@kolbyb you're 100% correct that I should move to segment intersection tests instead. Particularly after I spent today tracking down the existing bugs. I'm going to take a slightly different approach than you, I think.

kolbyb commented 1 year ago

@lefticus - I ported my Cppyy branch back to Python. I highly suspect you won't be interested in taking any of the changes however, you might be interested in how I structured the code into modules. Perhaps it could be of use if you wanted to restructure the code in any way.

You can check out the commit here: https://github.com/kolbyb/raycasting/commit/7d2efc73de46bf2620bb0bebdeb116786e83d370

lefticus commented 1 year ago

@lefticus - I ported my Cppyy branch back to Python. I highly suspect you won't be interested in taking any of the changes however, you might be interested in how I structured the code into modules. Perhaps it could be of use if you wanted to restructure the code in any way.

You can check out the commit here: kolbyb@7d2efc7

I do plan to eventually port all of this to C++, and it would be interesting to keep it in such a way that it can be used as C++/Cppyy/Python/whatever