leftstick / vscode-favorites

An extension helps developer marking resources as favorite. Therefor, those resources can be easily found at a special view
https://leftstick.gitbooks.io/vscode-favorites/
GNU General Public License v3.0
49 stars 22 forks source link

Dropped MANUAL sort #10

Closed kdcro101 closed 6 years ago

kdcro101 commented 6 years ago

@leftstick ,

In this PR i have removed MANUAL sort altogether.

Why?

If you sort root nodes as MANUAL what will you do with child/descendant items? What sort direction? You can't sort descendants as manual because you would have to:

If you drop MANUAL everything gets in predictable order : ASC or DESC.

leftstick commented 6 years ago

First, I am really appreciated for your contribution. But i 'm sorry i cannot merge your code. Here are some tips for you:

  1. one thing for one PR, too many updates in one PR is not friendly to repo owner
  2. never format code in a different way while it's not your target
  3. remove feature is not an easy story, you don't know how many developers working rely on it. Even it is not perfectly implemented