search

leftstick / vscode-favorites

An extension helps developer marking resources as favorite. Therefor, those resources can be easily found at a special view
https://leftstick.gitbooks.io/vscode-favorites/
GNU General Public License v3.0
49 stars 22 forks source link

Config filename should be .vscfavoritesrc #71

Open donysukardi opened 1 year ago

donysukardi commented 1 year ago

Given that the extension name is favorites, the config file name should be .vscfavoritesrc.

Is the config filename currently customisable by user?

I'd be open to contribute on this

leftstick commented 1 year ago

sure, please raise a PR

GitMensch commented 1 year ago

@donysukardi Could you please adjust favorites.saveSeparated to be either boolean or string? That would allow to keep compatibility - boolean false would use the workspace, boolean true would use .vscfavoriterc and the string option would allow to use a configurable place.

Ideally you could include resolving some variables in that string, especially {env:VAR} and {config:SETTING}.

GitMensch commented 1 year ago

... note that this issue is actually a special subset of #61, it may should be closed as duplicate.

leftstick commented 1 year ago

Hi @GitMensch i don't really have time for this project recently. Please feel free to give PR if you have any idea to solve your issue. Thanks