leftstick / vscode-favorites

An extension helps developer marking resources as favorite. Therefor, those resources can be easily found at a special view
https://leftstick.gitbooks.io/vscode-favorites/
GNU General Public License v3.0
48 stars 22 forks source link

Add to Favorites breaks for files outside current workspace #83

Open onomou opened 1 week ago

onomou commented 1 week ago

I opened a file outside my current working directory, then used Ctrl + Shift + P to call Add to Favorites. Only part of the file path was added to .vscode\settings.json.

Actual output:

    "favorites.resources": [
        {
            "filePath": "evit_config.ini",
            "group": "Default"
        }
    ]

Expected output:

    "favorites.resources": [
        {
            "filePath": "C:\\Users\\          \\AppData\\Roaming\\pyRevit\\pyRevit_config.ini",
            "group": "Default"
        }
    ]

I edited settings.json to reflect the expected result, and it shows the entry correctly.

Add to Favorites Example

Using Add to Favorites with other files in the currently opened folder worked for me, so I think this is a parsing issue with individual file paths.

leftstick commented 1 week ago

@geforcesong will you look at it?