[Regression] Forbid Unwraps; Enable Clippy Restricted Lints

[ixzh]

I have the following error:

    Retrieving themes from "community"
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/models/config.rs:219:69
stack backtrace:

What can I do?

   _______      bo@nana
 _ \______ -     os     Void Linux
| \  ___  \ |    kernel 5.13.15_1
| | /   \ | |    pkgs   856
| | \___/ | |    memory 1855M / 3838M
| \______ \_|    de     xmonad
 -_______\       shell  bash

[mautamu]

Is this a new installation? (Do you have themes already added/installed?)

Do you perchance know which git hash you’re using?

[ixzh]

it's new installation I have manually created the ~/.config/leftwm folder and having this error. im using git master.

[mautamu]

Ah, I have a theory about why this is happening. Do you mind going back to https://github.com/leftwm/leftwm-theme/commit/e6907a663ec56397ccbe4f1226ac0550ec6678f0 and seeing if that works for you?

[mautamu]

If it doesn't, you might need to create the ~/.config/leftwm/themes/ folder yourself

[ixzh]

it's the same:

[mautamu]

I was able to reproduce this, leftwm-theme does work at e6907a6 for me (with no themes.toml or themes folder).

Steps to fix:

git checkout e6907a663ec56397ccbe4f1226ac0550ec6678f0
cargo build --release
./target/release/leftwm-theme update

The issue is the call to unwrap() introduced in 6957c635827364fe493ae2724f7715412111548f. Will try to come up with a patch later tonight.

[mautamu]

@ixzh Does 1f1d521af8a11589a2ce9c6027cd7c7f64cdca1c work for you?

We'll need to add pedantic clippy lints to the workflow to catch this in the future. Could also add a blank-dir test.

[ixzh]

it works！ Thanks and close this issue？

[mautamu]

We can hold off on that for now, I’ll rename this to enable protective clippy lints.

[mautamu]

Thanks for reporting this @ixzh! Glad we got it working again for you.