Update theme incompatibility language and don't list unusable themes

leftwm / leftwm-theme

A tool to help manage themes for LeftWM

BSD 3-Clause "New" or "Revised" License

117 stars 12 forks source link

Update theme incompatibility language and don't list unusable themes #54

Closed copypasteonly closed 2 years ago

copypasteonly commented 2 years ago

When running leftwm-theme apply Catppuccin three rrors appear mainly

This theme is incompatible with the installed version of LeftWM. Not all prerequirements passed Operation did not complete successfully

I just installed leftwm in a vm, no changes were made to the config file.Picom, dmenu, rofi, and polybar are installed.

mautamu commented 2 years ago

Hello, try updating now that leftwm-community-themes's file list is updated. If it persists, this error is intentional as the theme is not compatible with the version of leftwm you're using.

To bring it up to compatibility, it will likely need a rewrite of the theme's shell scripts, namely up and down, to use leftwm-command rather than commands.pipe.

copypasteonly commented 2 years ago

Hello, try updating now that leftwm-community-themes's file list is updated. If it persists, this error is intentional as the theme is not compatible with the version of leftwm you're using.

To bring it up to compatibility, it will likely need a rewrite of the theme's shell scripts, namely up and down, to use leftwm-command rather than commands.pipe.

Hello thank you so much, I only tried Catppuccin and didnt try others lol other themes are working. By the way should i still put dunst, picom, feh etc. on my .xinitrc since from what I can see it's already being called in the up file and I'm going to assume that my .xinitrc is getting executed first before the up file. Thanks!

mautamu commented 2 years ago

I'm not certain about the order of execution, but I believe you're correct that .xinitrc and autostart go first.

mautamu commented 2 years ago

The current error messages are not super helpful, it would be more useful to:

[x] De-list themes (or denote themes) that are not usable with the currently installed leftwm (tracking: https://github.com/leftwm/leftwm-theme/issues/53)
[x] Update the error message to convey that the error is not necessarily the end-all be all, the theme just needs updated. Perhaps create a wiki page of how to migrate versions?