search

leftwm / leftwm-theme

A tool to help manage themes for LeftWM
BSD 3-Clause "New" or "Revised" License
117 stars 12 forks source link

leftwm-theme error for libgit2 >= 1.5 #64

Closed stevensonmt closed 8 months ago

stevensonmt commented 1 year ago

Describe the bug

$ leftwm-theme --help
leftwm-theme: error while loading shared libraries: libgit2.so.1.4: cannot open shared object file: No such file or directory

Expected behavior (optional)

Should allow libgit2 >= some minimal version rather than being fixed on specific version.

Steps to reproduce (optional)

Upgrade libgit2 to 1.5. Run leftwm-theme.

Relevant log output (optional)

No response

OS / Distro

Linux 6.1.5-arch2-1

Additional System Information (optional)

No response

LeftWM Check

$ leftwm-check
:: LeftWM version: 0.4.1
:: LeftWM git hash: 438b073
:: Enabled features: default journald-log lefthk lefthk-core tracing-journald
:: Checking feature dependencies . . .
    -> journald-log OK
    -> lefthk OK
:: Loading configuration . . .
    -> Configuration loaded OK
:: Checking keybinds . . .
    -> All keybinds OK
:: Checking environment . . .
    -> Environment OK
:: Checking theme . . .
WARN: TOML as config format is about to be deprecated.
      Please consider migrating to RON or contact the theme creator about this topic.
      Note: make sure the `up` script is loading the correct theme file.
WARN: TOML as config format is about to be deprecated.
      Please consider migrating to RON or contact the theme creator about this topic.
      Note: make sure the `up` script is loading the correct theme file.
ERROR: File not found: theme.ron
VuiMuich commented 1 year ago

I believe this belongs to the leftwm-theme repo, actually. @mautamu do you think you could look into this, as you are still more familiar with this one?

stevensonmt commented 1 year ago

I think this was a me issue not a leftwm issue.

bfg-coding commented 1 year ago

@stevensonmt how did you resolve this? I'm having the same issue

stevensonmt commented 1 year ago

I had somehow gotten libgit2 ahead of the Arch extra repo (I had temporarily enabled testing at one point and forgot). I just downgraded libgit2 back to the version 1.5 in extra. I haven't tried to build leftwm since the repo version went to 1.6 though. Looks like the issue is the git2 version in Cargo.toml is fixed on 0.15. git2 = {version = "0.17"} would probably fix the issue so I'm reopening the issue.

stevensonmt commented 9 months ago

I think this got reintroduced. I'm getting the same error with leftwm-theme now with 0.5.1-2 installed from AUR package. Looks like git2 crate is up to 0.18. Not able to check if that fixes the issue just now.

I wonder if adding vendored-libgit2 to required features in cargo.toml would future proof this at all. For now I've just done a probably dumb thing and symlinked the current libgit2.so to libgit2.so.1.4. Seems to work as far as leftwm-theme is concerned.