Socket.io update changes behavior

leftyfl1p / homebridge-poolcontroller

Homebridge plugin for Pentair pools

5 stars 5 forks source link

Socket.io update changes behavior #2

Closed wagnerec closed 6 years ago

wagnerec commented 6 years ago

Did a fresh install and the socket.io behavior changes a bit. Fix was: Line 41, reconnect had to be changed to reconnection Line 59, change from for (var i = 0; i < circuitData.length; i++) to for( i in circuitData) same for line 106

leftyfl1p commented 6 years ago

Take a look at the refactor branch, the entire thing has been rewritten to be updated with the new pool-controller API. The current branch is pretty outdated and we should probably merge the two anyways.

leftyfl1p commented 6 years ago

Closing as inactive.