leg100 / pug

Drive terraform at terminal velocity.
Mozilla Public License 2.0
439 stars 7 forks source link

Support NO_COLOR to turn off the color scheme #93

Closed chenrui333 closed 2 months ago

chenrui333 commented 2 months ago

Would be good to support NO_COLOR env to disable the color output.

https://no-color.org/

leg100 commented 2 months ago

Specifying NO_COLOR does already turn off colors in Pug, but I noticed the following:

Is this what you are seeing?

Out of interest, what is the use case?

chenrui333 commented 2 months ago

it is used for CI to check the output in my case, but it would be good to support NO_COLOR in general

leg100 commented 2 months ago

Can you please confirm whether you are seeing the above?

leg100 commented 2 months ago

Pug serves no purpose in a CI context, so I don't see a use case.

I don't think NO_COLOR makes much sense for a TUI. I checked out both tig, and k9s, both well established TUIs, and neither supports NO_COLOR.

chenrui333 commented 2 months ago

yeah, it is fine.